-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-32241: [release-4.12] dashboard: use recording rules for most metrics #1667
base: release-4.12
Are you sure you want to change the base?
Conversation
Add more recording rules to reduce the load on Thanos querier and Prometheus. This removes "auto" interval as it can't be cached via recording rules
Move recording rules out of `kube-apiserver` PrometheusRule as it is being removed by CVO (has "delete" annotation)
Update recording rules to include openshift-oauth-apiserver too
In order to avoid additional load on Prometheus the recording rules for kube-apiserver dashboard are not included when Console capability is not enablked . These are not used anywhere else, so it should not affect any other components.
In previous PR this manifests was labelled as "available only when Console capability enabled". This causes CVO to force enable Console capability when upgrading from baseline 4.13 cluster - as this manifest is present. In order to avoid this, the manifest needs to be renamed, so that CVO would treat it as a new one (since its applicability has changed)
/jira cherrypick OCPBUGS-25922 |
@vrutkovs: Jira Issue OCPBUGS-25922 has been cloned as Jira Issue OCPBUGS-32241. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@vrutkovs: This pull request references Jira Issue OCPBUGS-32241, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/jira refresh |
@vrutkovs: This pull request references Jira Issue OCPBUGS-32241, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label cherry-pick-approved |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Add more recording rules to reduce the load on Thanos querier and Prometheus.
This removes "auto" interval as it can't be cached via recording rules.
Cherrypick of #1611 on release-4.12